Skip to content

fix(nextjs): Continue traces in data fetchers when there is an already active transaction on the hub #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented May 8, 2023

Probably fixes #8025

Continues transactions on the hub in data fetchers instead of always creating a new one when there is none associated with the request object yet.

@lforst lforst requested a review from Lms24 May 8, 2023 16:09
@lforst lforst changed the title fix(nextjs): Continue traces in data fetchers when there is an already active transaction fix(nextjs): Continue traces in data fetchers when there is an already active transaction on the hub May 8, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Luca Forstner added 2 commits May 8, 2023 16:17
@lforst lforst merged commit 4d7ac23 into develop May 8, 2023
@lforst lforst deleted the lforst-continue-custom-server-traces branch May 8, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue trace from internal Next.js Request calls
2 participants